Daniel Rall wrote:
> Thanks for the patch, Kamesh. I've made some changes to it and the
> change log message (attached), but I have some additional questions:
>
> Is it 1) appropriate and 2) necessary to push knowledge of skels
> corresponding to specific properties (e.g. SVN_FS_PROP_TXN_MERGEINFO)
> down into fs_skels.c (rather than knowledge which ends at the concept
> of "proplists", as on trunk)? To me, that file seems like a more
> generic utility which shouldn't contain such specific knowledge.
>
I think somehow we can't avoid that. Someway or the other parsing
code(which should sit inside the util/fs_skel.c) should know about
'SVN_FS_PROP_TXN_MERGEINFO'. Or we should treat the value of
'svn:txn-mergeinfo' as 'atom' and parse it outside?
> In fs_skels.c:is_valid_proplist_skel(), the property name and length
> used to check whether we have a transaction merge info property are
> being set *after* being used, to values which always lag one iteration
> behind. Is this correct?
>
Yes.
I will go through you patch and get back.
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 11 16:24:30 2006