[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][merge-tracking]sqlite mergeinfo indexing for bdb repositories

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-10-11 02:44:37 CEST

Thanks for the patch, Kamesh. I've made some changes to it and the
change log message (attached), but I have some additional questions:

Is it 1) appropriate and 2) necessary to push knowledge of skels
corresponding to specific properties (e.g. SVN_FS_PROP_TXN_MERGEINFO)
down into fs_skels.c (rather than knowledge which ends at the concept
of "proplists", as on trunk)? To me, that file seems like a more
generic utility which shouldn't contain such specific knowledge.

In fs_skels.c:is_valid_proplist_skel(), the property name and length
used to check whether we have a transaction merge info property are
being set *after* being used, to values which always lag one iteration
behind. Is this correct?

  • application/pgp-signature attachment: stored
Received on Wed Oct 11 02:43:14 2006

This is an archived mail posted to the Subversion Dev mailing list.