[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] why not loop through apr_hash_t with pool as NULL.

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-10-07 00:49:30 CEST

On Fri, 06 Oct 2006, Philip Martin wrote:

> Daniel Rall <dlr@collab.net> writes:
...
> > /* KEY will be the entry name in ancestor (about which we
> > simple don't care), VAL the dirent. */
> > apr_hash_this(hi, NULL, NULL, &val);
> > entry = val;
> > nk_args.id = entry->id;
> > SVN_ERR(svn_fs_base__retry_txn(fs, txn_body_node_kind, &nk_args,
> > - pool));
> > + subpool));
> > entry->kind = nk_args.kind;
> > }
> > + svn_pool_destroy(subpool);
> > }
> > else
> > {
> >
> > This may not provide meaningful memory savings -- how expensive is
> > svn_fs_base__retry_txn()?
>
> Not expensive enough for anyone to notice so far :)

:-)

I've removed use of the sub-pool in r21818.

  • application/pgp-signature attachment: stored
Received on Sat Oct 7 00:50:54 2006

This is an archived mail posted to the Subversion Dev mailing list.