Re: svn commit: r21797 - in trunk: . subversion/tests/cmdline subversion/tests/cmdline/svntest

"David Glasser" <glasser@mit.edu> writes:

> * This is a bug and should be fixed by removing all the mtime and size
> checks from svn_cl__edit_externally and just using an equality check.
> Sounds easy, except for dealing with LF conversions etc.

Do the equality check only if the time/size checks show no change?

> * This is a bug and should be fixed by adding svn_sleep_for_timestamps
> to svn_cl__edit_externally. This does work, but I don't really think
> we want every single command that asks for a log message to take an
> extra second. (This is probably never an issue for log messages
> anyway since you really ought to always change the size; I can
> certainly imagine propedits that don't change the size and that you
> can do very quickly.)

I don't like the idea of adding sleep.

The mock editor doesn't work in my builddir != srcdir build either as
it looks in the builddir, perhaps use something like this:

Index: subversion/tests/cmdline/svntest/main.py
===================================================================
--- subversion/tests/cmdline/svntest/main.py (revision 21798)
+++ subversion/tests/cmdline/svntest/main.py (working copy)
@@ -115,7 +115,7 @@
 svnversion_binary = os.path.abspath('../../svnversion/svnversion' + _exe)
 
 # The location of our mock svneditor script.
-svneditor_script = os.path.abspath('svneditor.py')
+svneditor_script = os.path.join(sys.path[0], 'svneditor.py')
 
 # Username and password used by the working copies
 wc_author = 'jrandom'

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org