[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] why not loop through apr_hash_t with pool as NULL.

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-10-07 00:07:01 CEST

On 10/6/06, Philip Martin <philip@codematters.co.uk> wrote:
> "Garrett Rooney" <rooneg@electricjellyfish.net> writes:
>
> > Is that hash table actually accessed from multiple threads? The vast
> > majority of our code consists of data structures that are not shared
> > among more than oen thread...
>
> Good point. On the other hand, given that it's only a single
> iterator, simply using pool avoids the question now and in the future.

True, assuming we have a pool available it's almost certainly the
right thing to do, since it's an infintesimally small amount of memory
to use, and at the very least it keeps someone from copying this code
into someplace where thread safety does matter and screwing things up.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 7 00:07:16 2006

This is an archived mail posted to the Subversion Dev mailing list.