Re: svn commit: r18758 - in trunk/subversion/bindings/swig: include perl/libsvn_swig_perl perl/native perl/native/t

On Tue, 03 Oct 2006, Garrett Rooney wrote:

> On 10/3/06, David James <djames@collab.net> wrote:
> >On 3/7/06, rooneg@tigris.org <rooneg@tigris.org> wrote:
> >> Author: rooneg
> >> +/* Thunked version of svn_client_info_t callback type. */
> >> +svn_error_t *svn_swig_pl_info_receiver(void *baton,
> >> + const char *path,
> >> + const svn_info_t *info,
> >> + apr_pool_t *pool)
> >> +{
> >> + SV *result;
> >> + svn_error_t *ret_val;
> >> + swig_type_info *infoinfo = _SWIG_TYPE("svn_info_t *");
> >> +
> >> + if (!SvOK((SV *)baton))
> >> + return;
> >
> >It isn't valid to include a bare return statement in a function that
> >returns svn_error_t *. Did you intend to return an error here?
>
> Oops, yeah, that does indeed look like a bug. Anyone got an idea what
> kind of error it should return?

Some sort of invalid input error...