[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18758 - in trunk/subversion/bindings/swig: include perl/libsvn_swig_perl perl/native perl/native/t

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-10-03 20:32:30 CEST

On 10/3/06, David James <djames@collab.net> wrote:
> On 3/7/06, rooneg@tigris.org <rooneg@tigris.org> wrote:
> > Author: rooneg
> > +/* Thunked version of svn_client_info_t callback type. */
> > +svn_error_t *svn_swig_pl_info_receiver(void *baton,
> > + const char *path,
> > + const svn_info_t *info,
> > + apr_pool_t *pool)
> > +{
> > + SV *result;
> > + svn_error_t *ret_val;
> > + swig_type_info *infoinfo = _SWIG_TYPE("svn_info_t *");
> > +
> > + if (!SvOK((SV *)baton))
> > + return;
>
> It isn't valid to include a bare return statement in a function that
> returns svn_error_t *. Did you intend to return an error here?

Oops, yeah, that does indeed look like a bug. Anyone got an idea what
kind of error it should return?

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 3 20:32:51 2006

This is an archived mail posted to the Subversion Dev mailing list.