[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21710 - in branches/incomplete-directories/subversion: include libsvn_ra libsvn_ra_dav libsvn_ra_local libsvn_ra_serf libsvn_ra_svn libsvn_repos mod_dav_svn/reports svnserve tests/libsvn_repos

From: David Glasser <glasser_at_mit.edu>
Date: 2006-09-29 03:25:50 CEST

On 9/28/06, kfogel@tigris.org <kfogel@tigris.org> wrote:

> +/* Return svn_depth_t depth based on boolen RECURSE. This is a helper
> + for translating from the old pre-depth API. */
> +#define UNFOLD_TO_DEPTH(recurse) \
> + (recurse) ? svn_depth_infinity : svn_depth_zero

> +#define FOLD_FROM_DEPTH(depth) ((depth) == svn_depth_infinity) ? TRUE : FALSE

Tiny nit: Maybe I'm just too paranoid about macros, but I'd wrap the
right-hand side of each of these in parentheses, in case somebody
later accidentally used this in a context like "UNFOLD_TO_DEPTH(r) ==
svn_depth_infinity". Yeah, I know they're just for the compatibility
layer, but it can't hurt... (Or just make them into functions.)

(Also, s/boolen/boolean/.)


David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 29 03:26:05 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.