On Sep 27, 2006, at 6:35 PM, C. Michael Pilato wrote:
> wein@tigris.org wrote:
>> Author: wein
>> Date: Wed Sep 27 12:56:57 2006
>> New Revision: 21684
>>
>> Log:
>> Add property handling to mailer.py's commit messages.
>>
>> It is now possible to also report changes of properties (including
>> diffs) with a commit message. Therefor several new classes were
> ^^^ "Therefore"
>> added to mailer.py. To configure the reporting of property changes
>> four new parameters are added to mailer.conf. Without adding these
>> parameters to an existing configuration file no property changes
>> will be reported.
>>
>> New configuration parameters:
>> show_props configure which property changes to report
>> (valid options are any combination of
>> 'add_path add copy_path modify delete_path
>> delete')
>> ignore_props configure which property names shall be
>> ignored
>> in the list of changed properties
>> generate_propdiffs configure for which property changes diffs
>> shall be created
>> (valid options are any combination of
>> 'add_path add copy_path modify delete_path
>> delete')
>> ignore_propdiffs configure which property names shall be
>> ignored
>> when creating diffs for changed properties
>>
>> * tools/hook-scripts/mailer/mailer.py
>> New classes:
>> PropSelections
>> PropDiffSelections
>> PropDiffGenerator.
>> New functions:
>> TextCommitRenderer._get_prop_list
>> TextCommitRenderer._render_props
>> TextCommitRenderer.__render_props
>> TextCommitRenderer._render_propdiffs
>> TextCommitRenderer.__render_propdiffs.
>> Several appropriate changes to other classes and functions.
>>
>> * tools/hook-scripts/mailer/mailer.conf.example
>> New parameters show_props, ignore_props, generate_propdiffs and
>> ignore_propdiffs.
>>
>> * tools/hook-scripts/mailer/tests/mailer.conf
>> New parameters show_props, ignore_props, generate_propdiffs and
>> ignore_propdiffs.
>>
>> * tools/hook-scripts/mailer/tests/mailer-t1.output
>> Now containing property changes.
>>
>> Modified:
>> trunk/tools/hook-scripts/mailer/mailer.conf.example
>> trunk/tools/hook-scripts/mailer/mailer.py
>> trunk/tools/hook-scripts/mailer/tests/mailer-t1.output
>> trunk/tools/hook-scripts/mailer/tests/mailer.conf
>>
>> Modified: trunk/tools/hook-scripts/mailer/mailer.conf.example
>> URL: http://svn.collab.net/viewvc/svn/trunk/tools/hook-scripts/
>> mailer/mailer.conf.example?pathrev=21684&r1=21683&r2=21684
>> =====================================================================
>> =========
>> --- trunk/tools/hook-scripts/mailer/mailer.conf.example (original)
>> +++ trunk/tools/hook-scripts/mailer/mailer.conf.example Wed Sep 27
>> 12:56:57 2006
>> @@ -193,6 +193,52 @@
>> # delete: generates diffs for all removed paths
>> generate_diffs = add copy modify
>>
>> +# Specify which types of property changes mailer.py will report as a
>> +# summary at the top of the message, after the summary of changed
>> paths.
>> +# Valid options are any combination of 'add_path add copy_path
>> modify
>> +# delete_path delete'.
>> +# If the show_props option is empty, no list of changed
>> properties will
>> +# be created.
>> +# Meaning of the possible values:
>> +# add_path: lists all properties added with a newly added paths
>> +# add: lists all added properties not including the ones
>> added
>> +# for newly added paths
>> +# copy_path: lists all properties which were implicitly added by
>> +# making a copy of a path and not changed or removed
>> after
>> +# copying
>> +# modify: lists all modified properties, including the ones
>> that
>> +# were added by making a copy of a path and modified
>> +# afterwards (within the same commit)
>> +# delete_path: lists all properties removed with a path
>> +# delete: lists all removed properties not including the
>> ones for
>> +# removed paths
>> +show_props = add modify delete
>
> That's, uh, purty complex stuff you've got there. You sure all
> that is
> necessary?
>
>> +
>> +# When set to a regular expression all properties matching this
>> regular
>> +# expression will not be included in the summary of changed
>> properties.
>> +# Example (ignore all internal properties, i. e. all properties
>> +# starting with 'svn:'):
>> +# ignore_props = ^svn:
>> +ignore_props = ^svn:
>
> I'm not sure if the example file should actually ignore the svn:
> properties -- ideally, a person should get the typically desired
> behavior with the minimal number of edits to a copy of those sample
> file, and I suspect most folks want to see that svn: properties were
> changed.
Agreed. Most of the time people will be changing the svn: properties
and I would like to see diffs for them by default.
> Yikes?! Does that actually say "/dev/null"? And contain a
> malformatted
> date string? And bother to explain "empty, because property is newly
> added"?
>
> Also, what kind of problems can we expect to be caused by the fact
> that
> this diff output is something that appears (as far as I can tell)
> to be
> something 'patch' would actually try to apply? That's bad news.
>
> ~ ~ ~ ~ ~
>
> In summary, I'm all for mailer.py showing diffs of properties, but
> those
> diffs *must not* appear as something 'patch' will try to understand
> and
> apply. Further, I'm very much opposed to the propchange summary
> section, which I believe to be visually unwieldy and largely redundant
> with true property diffs. Finally, I think the sample file should
> reflect recommended default settings, even if more interesting things
> are explained yet commented-out.
Yes, the new changes seem much too complicated for what needs to be
seen for property diffs.
Regards,
Blair
--
Blair Zajac, Ph.D.
<blair@orcaware.com>
Subversion training, consulting and support
http://www.orcaware.com/svn/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 29 03:12:44 2006