[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21671 - in trunk/subversion: include include/private libsvn_client libsvn_fs_base/bdb libsvn_ra_svn libsvn_subr svnserve

From: David Glasser <glasser_at_mit.edu>
Date: 2006-09-27 04:05:32 CEST

On 9/26/06, dlr@tigris.org <dlr@tigris.org> wrote:
> --- trunk/subversion/libsvn_subr/hash.c (original)
> +++ trunk/subversion/libsvn_subr/hash.c Tue Sep 26 13:51:26 2006
> @@ -436,7 +436,7 @@
> /*** Misc. hash APIs ***/
> svn_error_t *
> -svn_hash_clear(apr_hash_t *hash)
> +svn_hash__clear(apr_hash_t *hash)
> {
> #if APR_VERSION_AT_LEAST(1, 3, 0)
> apr_hash_clear(hash);

Having a double-underscore function in the public API seems a little
strange. Should this be in an include/private/hash.h?

There is a bit of precedent in svn_sorts.h, but at the very least that
one is full of "THIS IS PRIVATE KEEP OFF" (and a statement that the
functionality should be added to APR, which doesn't seem to have
happened). Should we add a "private" indicator here, or move both
files into the private directory? (svn_sorts is a little odd, in that
it documents a struct and a function as private, but not some other
functions which use that struct as args.)


David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 27 04:05:49 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.