[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][merge-tracking] libsvn_fs_util(mass move)

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-09-27 02:24:30 CEST

On Tue, 26 Sep 2006, Kamesh Jayachandran wrote:
> Incorporated the review comments from Daniel Rall and Malcom Rowe except
> for the following.

I've committed this patch in r21673 -- we can make further refinements
there. I made several changes before committing, including:

o Renamed libsvn_fs_util/merge_info_indexer.c to

o Dropped private/fs_util.h, as its macro is currently only used by

o Renamed svn_fs_merge_info__db_create() to
svn_fs_merge_info__create_index(), orthogonal to the
svn_fs_merge_info__update_index() API.

o Added #define's around svn_fs_merge_info.h.

o Adding an SVN_ERR() macro around usage of
svn_fs_merge_info__update_index() in fs_fs.c to avoid discarding any
error it returns.

> 1)Mention 'sqlite' to libs/exes though they don't have a direct
> dependency on 'sqlite' akin to 'neon' to circumvent the libtool bug in
> convoluted setups.
> I moved this to a separate thread recording my observations.

Thanks for starting a separate thread.

> 2)Automatically create the mergeinfo db upon first usage.
> Would consider this as a separate exercise apart from this mass move.

I agree -- this can be considered separately.

  • application/pgp-signature attachment: stored
Received on Wed Sep 27 02:24:09 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.