On Fri, 22 Sep 2006, Bhuvaneswaran Arumugam wrote:
> On Thu, 2006-09-21 at 13:09 -0700, Daniel Rall wrote:
> > On Thu, 21 Sep 2006, Bhuvaneswaran Arumugam wrote:
> > ...
> > > If the path is a copy, add '+' character to the log message displayed in
> > > SVN_EDITOR.
> > >
> > > Patch by: me
> > > Kamesh Jayachandran <kamesh@collab.net>
> > >
> > > subversion/svn/util.c:
> > > * (svn_cl__get_log_message): Define new variable 'iscopy'('+'). If the
> > > path is a copy, add it to the log message displayed in SVN_EDITOR.
> >
> > David James and I went over this patch, and came up with a revised
> > version (to avoid changing the level of indention), which produces the
> > following output for copies/moves:
>
> Thank you! Committed this fix in r21604.
Bhuvaneswaran, I didn't intend to imply approval to commit this change
yet, as I first wanted to give other developers a chance to review the
user experience impact.
> > Note that while this is in line with the output of 'svn status',
> > 'status' actually describes 6 columns of output. Our feeling is that
> > only the 4 columns available here are valuable for inclusion in the
> > generated change log message.
>
> As you said, we print 6 columns for 'svn status' and 4 columns for log
> message printed in SVN_EDITOR during 'svn commit'. Will it be necessary
> to make 'svn status' print 4 columns for consistency sake?
Absolutely not -- that would remove information from the output of
'status'!. I was only pointing out the fact that there was a
discrepancy between the generated log message and our 'status' output.
- application/pgp-signature attachment: stored
Received on Fri Sep 22 19:31:30 2006