[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add '+' character if it is a copy

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2006-09-22 05:46:38 CEST

On Thu, 2006-09-21 at 13:09 -0700, Daniel Rall wrote:
> On Thu, 21 Sep 2006, Bhuvaneswaran Arumugam wrote:
> ...
> > If the path is a copy, add '+' character to the log message displayed in
> > SVN_EDITOR.
> >
> > Patch by: me
> > Kamesh Jayachandran <kamesh@collab.net>
> >
> > subversion/svn/util.c:
> > * (svn_cl__get_log_message): Define new variable 'iscopy'('+'). If the
> > path is a copy, add it to the log message displayed in SVN_EDITOR.
>
> David James and I went over this patch, and came up with a revised
> version (to avoid changing the level of indention), which produces the
> following output for copies/moves:

Thank you! Committed this fix in r21604.

> Note that while this is in line with the output of 'svn status',
> 'status' actually describes 6 columns of output. Our feeling is that
> only the 4 columns available here are valuable for inclusion in the
> generated change log message.

As you said, we print 6 columns for 'svn status' and 4 columns for log
message printed in SVN_EDITOR during 'svn commit'. Will it be necessary
to make 'svn status' print 4 columns for consistency sake?

-- 
Regards,
Bhuvaneswaran

Received on Fri Sep 22 05:46:58 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.