[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: APR version/API compatibility issues

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2006-09-21 08:57:43 CEST

> I was considering using Kamesh's fix for a permanent solution to the
> compilation problem I introduced yesterday for pre-1.3.0 APR libraries
> (which David Glasser fixed, and I spruced up), which boiled down to
> usage of the APR_VERSION_AT_LEAST(1, 3, 0) macro, which wasn't
> introduced until about a month ago (in 1.3.0 itself).
> However, after talking things over on IRC, a more easily maintainable
> solution was suggested -- SVN_APR_VERSION_AT_LEAST(). This macro will
> both fix this particular case nicely, and allow us to more easily
> leverage any future new APIs from APR.

> As this isn't a publicly accessible macro, but does need to be shared
> across our code base, it was suggested that I put it in
> private/svn_compat.h. I'm attaching a patch which does that, and
> makes use of the macro.

Or, as we do with APR_ARRAY_IDX and APR_ARRAY_PUSH, you could just
define APR_VERSION_AT_LEAST conditionally when it's not defined...
(saves 4 characters)

I don't have a strong opinion either way, but consistency seems like
something to strive for.



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 21 08:58:13 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.