[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21570 - trunk/subversion/libsvn_subr

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-09-21 08:21:50 CEST

dlr@tigris.org wrote:
> Author: dlr
> Date: Wed Sep 20 14:40:44 2006
> New Revision: 21570
>
> Log:
> * subversion/libsvn_subr/hash.c
> (svn_hash_clear): Add some inline comments describing how r21564
> fixed the comilation problem introduced in r21561 with pre-1.3.0
> versions of APR.
>
>
> Modified:
> trunk/subversion/libsvn_subr/hash.c
>
> Modified: trunk/subversion/libsvn_subr/hash.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/hash.c?pathrev=21570&r1=21569&r2=21570
> ==============================================================================
> --- trunk/subversion/libsvn_subr/hash.c (original)
> +++ trunk/subversion/libsvn_subr/hash.c Wed Sep 20 14:40:44 2006
> @@ -437,7 +437,9 @@
> svn_error_t *
> svn_hash_clear(apr_hash_t *hash)
> {
> -#ifdef APR_VERSION_AT_LEAST
> +/* The APR_VERSION_AT_LEAST() macro is new in APR 1.3.0, which also
> + happens to be the minimum version we require. */
> +#ifdef APR_VERSION_AT_LEAST /* 1.3.0 */
>
I am somehow not happy about this approach because,
APR_VERSION_AT_LEAST is a different feature from apr_hash_clear even
though both happen to exist from apr-1.3.0.
It works but incorrect.
The correct approach I posted as a patch to r21561 followup email, which
somehow got overlooked. Anyway I will post the same as a independent thread.

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 21 08:21:31 2006

This is an archived mail posted to the Subversion Dev mailing list.