[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21554 - in trunk/subversion: include libsvn_ra_svn libsvn_repos svnserve

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2006-09-19 21:15:16 CEST

"Garrett Rooney" <rooneg@electricjellyfish.net> writes:

> Ok, one catch... ra_svn_sasl.h depends on ra_svn.h for one constant
> (SVN_RA_SVN__READBUF_SIZE). Now there's no way in hell that
> SVN_RA_SVN__READBUF_SIZE should live in ra_svn_sasl.h, and similarly,
> I'm not all that thrilled about ra_svn.h living in private/, since
> it's really not used outside of libsvn_ra_svn. Any thoughts on a
> proper home for that constant?

Ahh, the 4096 I queried in the original patch :) How about getting rid
of SVN_RA_SVN__DEFAULT_SECPROPS and using

void svn_ra_svn__default_secprops(sasl_security_properties_t *secprops);

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 19 21:15:37 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.