[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21540 - in trunk/subversion: libsvn_fs_fs tests/cmdline tests/libsvn_fs

From: David Glasser <glasser_at_mit.edu>
Date: 2006-09-19 16:34:59 CEST

On 9/19/06, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> Just wondering, but is there any reason that you made this an argument
> instead of setting the is_fresh_txn_root value at the callsites? It's a
> little... odd to see us changing the noderev as part of writing it out.

Heh, I probably should have justified that.

My feeling was, it would be a problem to forget to clear the flag at
one of the svn_fs_fs__put_node_revision callsites. Forcing it to be an
argument to the function meant there was no way somebody (myself
during this patch or somebody else later) could forget to do so.

> Secondly, could you improve the documentation for
> svn_fs_node_created_rev() so that we know what invariant we're depending
> on?

I'm not quite sure what you're referring to here.


David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 19 16:35:46 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.