Re: svn commit: r21540 - in trunk/subversion: libsvn_fs_fs tests/cmdline tests/libsvn_fs

Hi David,

Thanks for fixing this! Just two questions:

On Mon, Sep 18, 2006 at 02:31:25PM -0700, glasser@tigris.org wrote:
> svn_fs_fs__put_node_revision(svn_fs_t *fs,
> const svn_fs_id_t *id,
> node_revision_t *noderev,
> + svn_boolean_t fresh_txn_root,
> apr_pool_t *pool)
> {
> apr_file_t *noderev_file;
> const char *txn_id = svn_fs_fs__id_txn_id(id);
>
> + noderev->is_fresh_txn_root = fresh_txn_root;
> +
> if (! txn_id)
> return svn_error_create(SVN_ERR_FS_CORRUPT, NULL,
> _("Attempted to write to non-transaction"));

Just wondering, but is there any reason that you made this an argument
instead of setting the is_fresh_txn_root value at the callsites? It's a
little... odd to see us changing the noderev as part of writing it out.

Secondly, could you improve the documentation for
svn_fs_node_created_rev() so that we know what invariant we're depending
on?

Thanks,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 19 12:10:37 2006