[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 2607: svn keeps rewriting .svn/entries for committed items once for each item

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2006-09-11 21:53:19 CEST

"Garrett Rooney" <rooneg@electricjellyfish.net> writes:

> On 9/10/06, Erik Huelsmann <ehuels@gmail.com> wrote:
>> + /* Write our accumulation of log entries into a log file */
>> + SVN_ERR(svn_wc__write_log(adm_access, log_number, logtags, pool));
> I honestly have no idea here, this isn't my area of expertise, but is
> holding the log data in memory like that a good idea? Is it
> potentially big? Should we be appending to a temporary log file
> instead? Or is this just "the way it's done"?

The wc library supports multiple log files: log, log.1, log.2, etc.
and it was introduced to solve a similar entries rewriting problem
during update. I don't know whether Eric intended to use multiple log
file or not, his patch introduces the log_number variable but never
increments it.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 11 21:58:55 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.