On 9/10/06, Erik Huelsmann <ehuels@gmail.com> wrote:
> + logtags = svn_stringbuf_create("", pool);
> +
> + SVN_ERR(process_committed_leaf(logtags, path, adm_access,
> + new_revnum, rev_date, rev_author,
> + wcprop_changes,
> + remove_lock, remove_changelist,
> + digest, pool));
> +
> if (recurse)
> {
> apr_hash_t *entries;
> @@ -509,16 +532,28 @@
> a directory. Pass null for wcprop_changes, because the
> ones present in the current call are only applicable to
> this one committed item. */
> - SVN_ERR(svn_wc_process_committed4
> - (this_path, child_access,
> - (current_entry->kind == svn_node_dir) ? TRUE : FALSE,
> - new_revnum, rev_date, rev_author, NULL, FALSE,
> - remove_changelist, NULL, subpool));
> + if (current_entry->kind == svn_node_dir)
> + SVN_ERR(svn_wc_process_committed4
> + (this_path, child_access,
> + TRUE,
> + new_revnum, rev_date, rev_author, NULL, FALSE,
> + remove_changelist, NULL, subpool));
> + else
> + SVN_ERR(process_committed_leaf
> + (logtags, this_path, adm_access,
> + new_revnum, rev_date, rev_author, NULL, FALSE,
> + remove_changelist, NULL, subpool));
> }
>
> svn_pool_destroy(subpool);
> }
>
> + /* Write our accumulation of log entries into a log file */
> + SVN_ERR(svn_wc__write_log(adm_access, log_number, logtags, pool));
I honestly have no idea here, this isn't my area of expertise, but is
holding the log data in memory like that a good idea? Is it
potentially big? Should we be appending to a temporary log file
instead? Or is this just "the way it's done"?
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 11 21:03:29 2006