[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH][merge-tracking] generalized SQLITE_ERR macro

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-09-06 18:08:52 CEST

We have SQLITE_ROW too.
Initially thought the same, but after seeing SQLITE_ROW, I preferred to have a single macro and hence the patch.

With regards
Kamesh Jayachandran

-----Original Message-----
From: Daniel Berlin [mailto:dberlin@dberlin.org]
Sent: Wed 06/09/2006 19:30
To: Kamesh Jayachandran
Cc: SVN Dev
Subject: Re: [PATCH][merge-tracking] generalized SQLITE_ERR macro
On 9/6/06, Kamesh Jayachandran <kamesh@collab.net> wrote:
> Hi All,
> Find the attached patch and log.
> This patch makes SQLITE_ERR to check for any expected value instead of
> only 'SQLITE_OK'.

Uh, why?

There is only one interesting sqlite function that will return
something other than SQLITE_OK during it's normal behavior.
Note that basically *every* single instance you've added below uses
SQLITE_OK except for the statement stepping.
If you really want to do this, make a new macro that takes the value,
and use it in the one or two places that need something other than
Received on Wed Sep 6 18:31:31 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.