[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][merge-tracking] generalized SQLITE_ERR macro

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2006-09-06 16:00:04 CEST

On 9/6/06, Kamesh Jayachandran <kamesh@collab.net> wrote:
> Hi All,
>
> Find the attached patch and log.
> This patch makes SQLITE_ERR to check for any expected value instead of
> only 'SQLITE_OK'.
>

Uh, why?

There is only one interesting sqlite function that will return
something other than SQLITE_OK during it's normal behavior.
Note that basically *every* single instance you've added below uses
SQLITE_OK except for the statement stepping.
If you really want to do this, make a new macro that takes the value,
and use it in the one or two places that need something other than
SQLITE_OK.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 6 16:01:26 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.