[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] renaming the function as per convention

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-08-28 16:16:03 CEST

On 8/28/06, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> On Mon, Aug 28, 2006 at 01:57:32PM +0530, Kamesh Jayachandran wrote:
> > static function is not supposed to have 'svn_' prefix.
> > We use '__' in function names that is used by other 'C' files
> > within the same library.
> >
> > * subversion/libsvn_diff/diff4.c
> > (svn_diff__adjust): Renamed to _diff_adjust.
> > (svn_diff_diff4): Calls _diff_adjust.
> >
> I don't think we use leading underscores anywhere else; why not
> 'diff_adjust' (or even 'adjust_diff', since that presumably is a better
> description of what it's doing).

FWIW, the reason we don't is because any symbol with a leading
underscore is reserved for the C implementation, it's technically
illegal for anything outside the standard library and compiler to use


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 28 16:18:01 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.