[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

mailer.py propchange2 bugs and [PATCH]

From: techtonik <techtonik_at_gmail.com>
Date: 2006-08-17 14:30:36 CEST

Hi there!

Enclosed you will find a patch for mailer.py from 1.3.2
It lists two parts. First one demonstrates obscure bug I will describe later.

Second part fixes invocation of 'diff' utility. Second part is easy to
explain - mailer.py uses NamedTemporaryFile class, which does not
allow another process - i.e. diff to reopen created temp files - hence
'Permission denied' error is produced - this is well described here in
last post - http://www.thescripts.com/forum/thread439775.html
I changed the name NamedTemporaryFile to MailerTemporaryFile just
because I see the python for the first time and do not want to collect
possible bugs arising from name clashes. The second part also fixes
bug when temporary files were not deleted by custom TemporaryFile
class because they were not closed yet .

As for the first part - this is where am I looking for advice.
     """Override this method, if the default implementation is not sufficient.
     Execute CMD, writing the stdout produced to the output representation."""
     # By default we choose to incorporate child stderr into the output
+ os.system(svn.core.argv_to_command_string(cmd))
     pipe_ob = Popen4(cmd)
without this line diff results in mail with are blank. With it
everything is ok. I failed to find any logical explanation for this
fact. Any ideas why this can happen?

Win2003 server, python 2.3.5


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu Aug 17 14:31:17 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.