Re: [PATCH] #2592 check prop name before starting editor
Martin Furter wrote:
> Make svn_prop_name_is_valid public and use it in svn_cl__propedit to check
> the property name before starting an editor (issue 2592).
> * subversion/include/svn_props.h:
> Add prototype for svn_prop_name_is_valid.
> * subversion/libsvn_client/prop_commands.c
> (svn_client_propset2, svn_client_revprop_set):
> Replace is_valid_prop_name by svn_prop_name_is_valid.
> Remove this function...
> * subversion/libsvn_subr/sorts.c
> (svn_prop_name_is_valid): and paste it here.
> * subversion/svn/propedit-cmd.c
> Check property name early.
I committed a slightly modified version of this in r21106. My tweaks will
simple -- put the new function into the new properties.c file (instead of
sorts.c); added the @since 1.5 notation to the new API.
C. Michael Pilato <firstname.lastname@example.org>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on Thu Aug 17 09:18:00 2006
This is an archived mail posted to the Subversion Dev