[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] #2592 check prop name before starting editor

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-08-17 09:17:08 CEST

Martin Furter wrote:
>
> <<<
> Make svn_prop_name_is_valid public and use it in svn_cl__propedit to check
> the property name before starting an editor (issue 2592).
>
> * subversion/include/svn_props.h:
> Add prototype for svn_prop_name_is_valid.
> * subversion/libsvn_client/prop_commands.c
> (svn_client_propset2, svn_client_revprop_set):
> Replace is_valid_prop_name by svn_prop_name_is_valid.
> (is_valid_prop_name):
> Remove this function...
> * subversion/libsvn_subr/sorts.c
> (svn_prop_name_is_valid): and paste it here.
> * subversion/svn/propedit-cmd.c
> (svn_cl__propedit):
> Check property name early.

I committed a slightly modified version of this in r21106. My tweaks will
simple -- put the new function into the new properties.c file (instead of
sorts.c); added the @since 1.5 notation to the new API.

Thanks, Martin.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Thu Aug 17 09:18:00 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.