[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] #2592 check prop name before starting editor

From: Martin Furter <mf_at_rola.ch>
Date: 2006-08-10 19:14:32 CEST

Make svn_prop_name_is_valid public and use it in svn_cl__propedit to check
the property name before starting an editor (issue 2592).

* subversion/include/svn_props.h:
     Add prototype for svn_prop_name_is_valid.
* subversion/libsvn_client/prop_commands.c
   (svn_client_propset2, svn_client_revprop_set):
     Replace is_valid_prop_name by svn_prop_name_is_valid.
     Remove this function...
* subversion/libsvn_subr/sorts.c
   (svn_prop_name_is_valid): and paste it here.
* subversion/svn/propedit-cmd.c
     Check property name early.

I didn't run the tests yet, but the patch seems to work so far.

When looking into prop_tests.py i saw that 'propedit' is not tested so I
started thinking about how to implement a test.

I'd have to set the editor-cmd to an application or script which puts a
value into the temp file (using touch leads to "No changes to property

Now if I add a python script which just writes 'foo' to the specified
file I could write a test for propedit, but:
1. How can i get the absolute path to that script?
2. Will that work on windos too?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu Aug 10 19:15:31 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.