[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for issue #2556: support working copies on the root of a (virtual) drive

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2006-08-17 00:09:02 CEST

> > In that case, could you provide 2 patches? It's best to
> > separate conceptually different changes into separate commits.
> Ok, attached you'll find two patches.


> > > 1. Introduce 'X:/' as a syntax for a root folder, on Windows.
> This change is contained in issue-2556-wc-on-root.patch.txt.

Regarding this patch: It's basically fine, but you skip testing for
the first character of "X:\\"<nul>, but that means you may be checking
past the end of the string. (this is in svn_path_is_root and further
down in the patch [the last hunk]; in is_canonical, you do it
Isn't it so that the X should be in the A-Za-z set of characters?
Should we explicitly test for that?

> > > 2. Fix an issue where Subversion thinks a working copy on a root path
> (both '/' and 'X:/') is switched.
> This change is contained in issue-2556-wc-switched.patch.txt.

I haven't had time to look into this patch yet; I'll come back to you later.

> I've used your comments to make two new commit messages.
> For issue-2556-wc-on-root.patch.txt:
> [[[
> Prepare fix for issue #2556: abstract root folder check in svn_path_is_root.
> Add support for 'X:/' as a root folder on Windows.
> * subversion/include/svn_path.h
> (svn_path_is_root): New function declaration.
> * subversion/libsvn_subr/path.c
> (svn_path_is_root): New function. Tests for either '/' on all platforms
> or 'X:/' on Windows.
> (is_canonical): 'X:/' syntax on Windows is canonical.
> (svn_path_join, svn_path_dirname, svn_path_basename): Support the new type
> of root path on Windows, mostly by replacing direct comparisons of path
> and '/' with a call to svn_path_is_root.
> (svn_path_canonicalize): don't strip the trailing slash if the path is
> of the 'X:/' syntax.
> * subversion/tests/cmdline/update_tests.py
> (update_wc_on_windows_drive): New test for issue 2556.
> (test_list): add the new test to the list.
> ]]]

These messages are fine now.

> For issue-2556-wc-switched.patch.txt:
> [[[
> Fix an issue where the status of a working copy on the root of a drive is
> 'S' (switched), as part of issue #2556.
> This is not Windows specific, this code didn't work for working copies on
> '/' either.
> * subversion/libsvn_wc/status.c
> (assemble_status): add support for working copies at the root of a
> (virtual)
> drive.
> ]]]



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 17 00:15:03 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.