Re: [PATCH] Client-side Cyrus SASL support

On 8/14/06, Vlad Georgescu <vgeorgescu@gmail.com> wrote:
> I made a couple of changes to this patch to make it compile
> successfully under win32. On Unix, we include <sasl/sasl.h>, but this
> doesn't work on windows, we need to include <sasl.h> because we use
> Cyrus SASL's include directory directly. We also need to define
> STRUCT_IOVEC_DEFINED, so that sasl.h doesn't try to redefine iovec
> (this was initially in D.J. Heap's patch, I moved it here to keep the
> solution close to the problem). See also:
> http://svn.haxx.se/dev/archive-2006-08/0411.shtml

It looks like the only thing left to resolve is Philip's question
about use of atexit versus pool cleanups for the sasl_done stuff.

I don't personally have a strong opinion on it, although I lean
towards agreeing with Philip since he's usually right.

On the other hand, this patch has been kicking around for quite some
time, so I'm starting to see some arguement in favor of just
committing what we've got now, and incrementally improving it once
it's in trunk.

Thoughts?

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 17 00:06:21 2006