[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix API doc parameter reference

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-08-14 22:52:33 CEST

Daniel Rall wrote:
> On Mon, 31 Jul 2006, Malcolm Rowe wrote:
>>>On Sat, 29 Jul 2006, Julian Foad wrote:
>>>>Rename some API parameters for consistency. This does not constitute an API
>>>>or ABI change, as the parameters are only within a pointer-to-function type.

Committed in r21071.

>>(Does renaming arguments ever constitute an API/ABI change?)

Probably not, in C. I removed the word "as" from the log message, so as not to
imply that it does.

>>On Sun, Jul 30, 2006 at 11:07:21PM -0700, Daniel Rall wrote:
>>>I'm guessing that our SWIG stuff doesn't expose this API, but if it
>>>does, it could have some impact there.
>>Why's that? Does SWIG depend upon the names of arguments used in
>>function declarations?
> Yeah, it does depend on parameter names.
> Alongside Julian's patch, should we also ditch the "copy_path"
> parameter from svn_delta.i? add_file() is the only place I see it
> used in svn_delta.h.
> Index: subversion/bindings/swig/svn_delta.i
> ===================================================================
> --- subversion/bindings/swig/svn_delta.i (revision 20914)
> +++ subversion/bindings/swig/svn_delta.i (working copy)
> @@ -34,7 +34,6 @@
> %apply const char *MAY_BE_NULL {
> const char *error_info,
> const char *copyfrom_path,
> - const char *copy_path,
> const char *base_checksum,
> const char *text_checksum
> };

I have never looked at SWIG and have got no idea about the change you are
suggesting here.

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 14 22:51:56 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.