[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] contribulyze.py: Turn off html_spam_guard for title

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2006-08-05 16:14:00 CEST

> >
> > [[
> > * tools/dev/contribulyze.py
> > (Contributor.big_name): Turn off html_spam_guard for title of the
> > author page
> A patch which removes the <span> tags in the <title> case would be ok,
> but the entity-encoding should be preserved, even in the <title>.

Ok. Please find attached the revised patch.

> > (Contributor.html_out): Fix the heading of patch table
> > - out.write('<td>%s</td>\n\n' % activity)
> > + if activity == 'Patch':
> > + out.write('<td>Patch List</td>\n\n')
> > + else:
> > + out.write('<td>%s</td>\n\n' % activity)
> I do not see this as a fix, I see it as an irrelevant complication to
> the code that adds no value.

IMO, the "Patch List" is more suitable than the word "Patch" since the
table lists link to multiple revisions. Anyhow, i have not included this
snippet in the attached patch.

> > PROPOSAL: I wish to make changes to this script to generate the html
> > content based on the output of 'svn log --xml' and/or 'svn log -v
> > --xml'. Comments are welcome! Thank you!
> Quoting contribulyze.py:
> # .-------------------------------------------------.
> # | "An ad hoc format deserves an ad hoc parser." |
> # `-------------------------------------------------'
> I see no reason to use XML just for the sake of using XML, when we
> already have proven working code for the non-XML format, if there are no
> significant advantages in doing so.

Ok! The below quote in the same script explains that using 'xml' based
input is the right thing to do, so, i have proposed this feature!

Quote from contribulyze.py:

# NOTES: You might be wondering, why not take 'svn log --xml' input?
# Well, that would be the Right Thing to do, but in practice this was
# a lot easier to whip up for straight 'svn log' output. I'd have no
# objection to it being rewritten to take XML input.

Thank you!


Received on Sat Aug 5 16:14:43 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.