[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] contribulyze.py: Turn off html_spam_guard for title

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2006-08-05 13:52:12 CEST

Bhuvaneswaran Arumugam wrote:
> Hello,
> Please find attached the patch.
> [[
> * tools/dev/contribulyze.py
> (Contributor.big_name): Turn off html_spam_guard for title of the
> author page

A patch which removes the <span> tags in the <title> case would be ok,
but the entity-encoding should be preserved, even in the <title>.

> (Contributor.html_out): Fix the heading of patch table
> - out.write('<td>%s</td>\n\n' % activity)
> + if activity == 'Patch':
> + out.write('<td>Patch List</td>\n\n')
> + else:
> + out.write('<td>%s</td>\n\n' % activity)

I do not see this as a fix, I see it as an irrelevant complication to
the code that adds no value.

> ]]
> PROPOSAL: I wish to make changes to this script to generate the html
> content based on the output of 'svn log --xml' and/or 'svn log -v
> --xml'. Comments are welcome! Thank you!

Quoting contribulyze.py:
# .-------------------------------------------------.
# | "An ad hoc format deserves an ad hoc parser." |
# `-------------------------------------------------'

I see no reason to use XML just for the sake of using XML, when we
already have proven working code for the non-XML format, if there are no
significant advantages in doing so.


Received on Sat Aug 5 13:52:54 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.