Re: svn commit: r20924 - branches/merge-tracking/subversion/libsvn_fs_fs

On Tue, 01 Aug 2006, Madan S. wrote:

> On Tue, 01 Aug 2006 03:29:33 +0530, <dlr@tigris.org> wrote:
>
> >Author: dlr
> >Date: Mon Jul 31 14:59:32 2006
> >New Revision: 20924
> >
> >Modified:
> > branches/merge-tracking/subversion/libsvn_fs_fs/fs_fs.c
> >
> >Log:
> >On the merge-tracking branch: Remove unnecessary open of a connection
> >to the sqlite database, since we currently always open it immediately
> >before use.
>
> uh.... am not able to put my finger on the problem... but this log message
> looks longer than necessary.
>
> Can't we just say 'Removed unnecessary connection to the sqllite database'?

No. The "why" is important.

> 'since we currently open it...' is unrelated to why we removed the open()
> call.

No, that's exactly why it was removed.

> Put the fact, that dberlin said "to check for connection
> establishment", and then things fall into perspective. But this is not
> necessary, I think.
>
> And 'immediately *before* use'?

Yes.