[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20924 - branches/merge-tracking/subversion/libsvn_fs_fs

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-08-01 10:05:08 CEST

On Tue, 01 Aug 2006 03:29:33 +0530, <dlr@tigris.org> wrote:

> Author: dlr
> Date: Mon Jul 31 14:59:32 2006
> New Revision: 20924
> Modified:
> branches/merge-tracking/subversion/libsvn_fs_fs/fs_fs.c
> Log:
> On the merge-tracking branch: Remove unnecessary open of a connection
> to the sqlite database, since we currently always open it immediately
> before use.

uh.... am not able to put my finger on the problem... but this log message
looks longer than necessary.

Can't we just say 'Removed unnecessary connection to the sqllite database'?

'since we currently open it...' is unrelated to why we removed the open()
call. Put the fact, that dberlin said "to check for connection
establishment", and then things fall into perspective. But this is not
necessary, I think.

And 'immediately *before* use'?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 1 09:35:04 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.