[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Updating exclusively opened files locks working copy

From: Eric Hanchrow <offby1_at_blarg.net>
Date: 2006-07-29 22:51:08 CEST

I know precisely nothing about APR programming, so forgive me if this
is stupid, but: doesn't this leak a file handle?

    + /* Make sure the file is not exclusively opened by someone else. */
    + if (!adding && entry && entry->schedule != svn_wc_schedule_delete)
    + {
    + apr_file_t* file;
    + SVN_ERR(svn_io_file_open(&file, fb->path, APR_READ, APR_OS_DEFAULT,
    + subpool));
    + }

-- 
... Most people never have to face the fact that at the right time
and right place, they're capable of using Emacs for anything.
        -- Noah Cross, Los Angeles Department of Water and Power
          (paraphrased slightly)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 29 22:53:43 2006

This is an archived mail posted to the Subversion Dev mailing list.