[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Provide support for the HTTPS url

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-07-29 22:28:13 CEST

Bhuvaneswaran Arumugam wrote:
> Provide support for the HTTPS url and few more enhancements.
>
> [[
> Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
>
> * tools/client-side/server-vsn.py
> (global): Do not import "string" library when it is not necessary and
> indent the script to 4 whitespaces.
> (print_version): Handle the HTTPS url. In httplib, the HTTP and HTTPS
> functions are included just for backward compatibility. Moreover,
> HTTPS support is only available if the socket module is compiled with
> SSL support. So, use HTTPConnection and HTTPSConnection functions
> instead.
>
> Handle redirect requests (302), if the requested resource resides
> temporarily under a different URL.
> ]]

Thank you for this patch.

I have committed it in 20902, except for the indentation change. We try to
keep wide-ranging whitespace changes separate from functional changes. In this
case, I can't see the reason for changing it: it appears that more of our
Python scripts use 2-space indentation than 4-space indentation.

> In addition, i suggest to rename this script as server-version.py as it
> makes more sense, imo.

Yes, I agree that would be better: "vsn" is not a common abbreviation of
"version". I will wait and see if anyone agrees or thinks we would need to
leave some kind of link under the old name.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 29 22:27:33 2006

This is an archived mail posted to the Subversion Dev mailing list.