[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] remove redudant code chunk

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2006-07-18 16:26:29 CEST

Madan U Sreenivasan wrote:
> Hi,
>
> While working on eliding for merge-tracking, I found a redundant call
> to apr_hash_set() in parse_mergeinfo_from_db. Pl. find attached a patch
> to fix this.

This was just a paste error, feel free to commit the fix.

>
> [[[
> Redundant code chunk removal.
>
> (In branches/merge-tracking)
>
> * subversion/libsvn_fs_fs/tree.c:
> (parse_mergeinfo_from_db): Remove redundant call to apr_hash_set().
> ]]]
>
> Also, on another line of thought, I was wondering why there is
> hardcoding of table names and column numbers when dealing with the sqlite
> tables. Couldn't we make these macros?

Yes, we could.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 18 16:27:30 2006

This is an archived mail posted to the Subversion Dev mailing list.