[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] remove redudant code chunk

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-07-15 10:41:17 CEST

Hi,

    While working on eliding for merge-tracking, I found a redundant call
to apr_hash_set() in parse_mergeinfo_from_db. Pl. find attached a patch
to fix this.

[[[
Redundant code chunk removal.

(In branches/merge-tracking)

* subversion/libsvn_fs_fs/tree.c:
   (parse_mergeinfo_from_db): Remove redundant call to apr_hash_set().
]]]

     Also, on another line of thought, I was wondering why there is
hardcoding of table names and column numbers when dealing with the sqlite
tables. Couldn't we make these macros?

Regards,
Madan.

Index: subversion/libsvn_fs_fs/tree.c
===================================================================
--- subversion/libsvn_fs_fs/tree.c (revision 20681)
+++ subversion/libsvn_fs_fs/tree.c (working copy)
@@ -1173,9 +1173,6 @@
       if (sqlite_result != SQLITE_DONE)
         return svn_error_create(SVN_ERR_FS_SQLITE_ERROR, NULL,
                                 sqlite3_errmsg(db));
-
- apr_hash_set(*result, mergedfrom, APR_HASH_KEY_STRING,
- pathranges);
     }
   else
     {

Redundant code chunk removal.

(In branches/merge-tracking)

* subversion/libsvn_fs_fs/tree.c:
  (parse_mergeinfo_from_db): Remove redundant call to apr_hash_set().

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 15 10:11:16 2006

This is an archived mail posted to the Subversion Dev mailing list.