[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20686 - trunk

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2006-07-15 19:05:45 CEST

Justin Erenkrantz wrote:
> On 7/15/06, Max Bowsher <maxb1@ukf.net> wrote:
>> Yes, this change was a change of the status quo, but as I see it, it was
>> merely cutting long-inappropriate legacy code. If there is reason to
>> consider it otherwise, please clarify that reasoning.
>
> The change breaks setups that we have supported for years

For some unintentional and fuzzy value of 'supported'.

> and there's
> no justifiable reason to remove it at this point silently. For people
> who a WC with this setup, it'll just silently break their
> environments.

Silently? How?

The OS X buildbot has already shown that the error is not silent.

> If you want to remove bundling - let's do that: remove support in
> Subversion for the ./apr, ./apr-util, ./neon dirs calling configure.

Eventually, yes, but probably not for a few more years.

> But, this change can and should not be sneaked in at the last moment
> into a release. -- justin

Nothing sneaky about it, it's going through STATUS just like everything
else. And, with our soak-starting RC not yet done, there's a minimum of
four weeks to go.

I agree this isn't the optimal timing, but we didn't notice that this
legacy code was hanging around until it interacted with the presence of
autoconf 2.60 to cause an actual bug, drawing attention to itself.

It's legacy code, present as a developer convenience for working
practices long obsolete, and it caused a bug. Therefore it was removed.

Max.

Received on Sat Jul 15 19:06:31 2006

This is an archived mail posted to the Subversion Dev mailing list.