[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] SASL support ready for review and testing

From: David Anderson <david.anderson_at_calixo.net>
Date: 2006-07-10 21:23:40 CEST

* Vlad Georgescu <vgeorgescu@gmail.com> [2006-07-10 21:09:22]:
> As things stand now, I could easily separate the server-only part from
> the client part. That would leave you with a lot of unused code on the
> client, though.

I don't see this as a problem. The big problem when reviewing patches
on our side, is that if they're too large, it scares people off, and
review takes much much longer.

As for the problem of finding bugs on the client after you started
work on the server code, this is no problem. I find this normal in a
development cycle. Once you've resubmitted your client patch by
itself, if later you find bugs, just resubmit a bugfix patch, with
just the fixes/enhancements to the client and a corresponding log
message.

Oh, and I'll second Garrett in saying that your work currently looks
just great! You seem to be making very good progress on your task.
But, again, if you could submit smaller patches a little more
frequently (eg. submit just the client side to start with), that would
give us better feedback on your progress, and would let us review
stuff as you go, instead of having large chunks to read at once.

Looking forward to reviewing your new client-side patch!

- Dave

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 10 21:23:53 2006

This is an archived mail posted to the Subversion Dev mailing list.