Re: [PATCH] SASL support ready for review and testing

On 7/10/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> First off, this is fantastic progress. I do worry though, that this
> patch is awfully large. I'd really prefer if you finished off, for
> example, just the client side of things, and got that in shape for
> commit, then sent in a separate patch for server side support. As it
> was we were getting quite close to being able to get the client code
> in, but now it's all intermingled with the server side of this patch,
> which makes it that much harder to review.
>
> -garrett
>

Well, when I started working on the server part, I realized I had
gotten a number of things wrong on the client side. For example, mechs
that send data along with the "success" message didn't work properly.
Rather than submit a crippled client, I decided to finish them both at
the same time. The same thing happened with the encryption part: I had
to go back and tweak a few things here and there.

As things stand now, I could easily separate the server-only part from
the client part. That would leave you with a lot of unused code on the
client, though.

-- 
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org