[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20449 - in trunk/subversion/bindings/swig/ruby: svn test

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2006-07-06 16:50:12 CEST

On Thu, Jul 06, 2006 at 11:37:49PM +0900, Kouhei Sutou wrote:
> > It might be a good idea to add a comment explaining that this is for
> > backwards compatibility with pre-1.5 bindings.
>
> OK. I added a comment in r20454.
>

Excellent, thanks.

> > > - assert_raises(Svn::Error::ENTRY_EXISTS) do
> > > + assert_raises(Svn::Error::EntryExists) do
> >
> > I assume that these changes are just to keep up with the new style -
> > they aren't actually required, are they?
>
> I want to recommend new style because new style is more
> standard Ruby style. I assume that test codes are sample
> codes too. So I want to use recommended style in test codes.
>

Yes, that's a good reason to change. I was just checking that existing
code that expected certain exceptions would still work (because the old
and new exceptions are identical).

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 6 16:53:54 2006

This is an archived mail posted to the Subversion Dev mailing list.