[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20449 - in trunk/subversion/bindings/swig/ruby: svn test

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2006-07-06 16:37:49 CEST

Hi,

In <20060706142310.GH12860@lorenz.farside.org.uk>
  "Re: svn commit: r20449 - in trunk/subversion/bindings/swig/ruby: svn test" on Thu, 6 Jul 2006 15:23:10 +0100,
  Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:

> > Use ClassName rule instead of CONSTANT_NAME rule for error class name.
> >
> > --- trunk/subversion/bindings/swig/ruby/svn/error.rb (original)
> > +++ trunk/subversion/bindings/swig/ruby/svn/error.rb Thu Jul 6 07:05:05 2006
> > @@ -1,4 +1,5 @@
> > + class #{error_class_name} < Error
> > def initialize(message="", file=nil, line=nil)
> > super(#{value}, message, file, line)
> > end
> > end
> > + #{error_const_name} = #{error_class_name}
>
> It might be a good idea to add a comment explaining that this is for
> backwards compatibility with pre-1.5 bindings.

OK. I added a comment in r20454.

> > --- trunk/subversion/bindings/swig/ruby/test/test_client.rb (original)
> > +++ trunk/subversion/bindings/swig/ruby/test/test_client.rb Thu Jul 6 07:05:05 2006
> > @@ -125,14 +125,14 @@
> > assert(!File.exist?(dir_path))
> > ctx.mkdir(dir_path)
> > assert(File.exist?(dir_path))
> > - assert_raises(Svn::Error::ENTRY_EXISTS) do
> > + assert_raises(Svn::Error::EntryExists) do
>
> I assume that these changes are just to keep up with the new style -
> they aren't actually required, are they?

I want to recommend new style because new style is more
standard Ruby style. I assume that test codes are sample
codes too. So I want to use recommended style in test codes.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 6 16:39:38 2006

This is an archived mail posted to the Subversion Dev mailing list.