[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix Python bindings for svn.ra.get_commit_editor()

From: Jelmer Vernooij <jelmer_at_samba.org>
Date: 2006-06-30 12:28:44 CEST

On Fri, 2006-06-30 at 14:17 +0530, Madan U Sreenivasan wrote:
> A general observation : Why should we add new bindings for alreadty
> deprecated functions/callbacks?
I'm using this to create bindings to Subversion 1.3, which doesn't have
get_commit_editor2(). If people don't think it belongs in trunk/, I'll
just use it locally.

> On Thu, 29 Jun 2006 19:42:59 +0530, Jelmer Vernooij <jelmer@samba.org>
> wrote:
>
> > Hi,
> >
> > [[[
> > Fix Python bindings to svn.ra.get_commit_editor().
> >
> > [ in subversion/bindings/swig ]
> >
> > * python/tests/ra.py
>
> Shouldn't the log containt the full path?
It does - see the [ in ] phrase above.

> [snip]
> > * python/libsvn_swig_py/swigutil_py.[ch]
> > (svn_swig_py_commit_callback): Add new function.
>
> + if ((result = PyObject_CallFunction(receiver,
> + (char *)"lss",
> + new_revision, date, author)) ==
> NULL)
>
> Could you give me some pointers to understand this call... especially the
> second parameter.
Why? There's nothing strange about it, it's just like all the other
PyObject_CallFunction() calls in that file.

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer_at_samba.org> - http://samba.org/~jelmer/

Received on Fri Jun 30 12:29:14 2006

This is an archived mail posted to the Subversion Dev mailing list.