[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix Python bindings for svn.ra.get_commit_editor()

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-06-30 10:47:33 CEST

A general observation : Why should we add new bindings for alreadty
deprecated functions/callbacks?

On Thu, 29 Jun 2006 19:42:59 +0530, Jelmer Vernooij <jelmer@samba.org>
wrote:

> Hi,
>
> [[[
> Fix Python bindings to svn.ra.get_commit_editor().
>
> [ in subversion/bindings/swig ]
>
> * python/tests/ra.py

Shouldn't the log containt the full path?
Also could you pl. bump up the copyright year for the files, while
committing.

[snip]
> * python/libsvn_swig_py/swigutil_py.[ch]
> (svn_swig_py_commit_callback): Add new function.

+ if ((result = PyObject_CallFunction(receiver,
+ (char *)"lss",
+ new_revision, date, author)) ==
NULL)

Could you give me some pointers to understand this call... especially the
second parameter.

[snip]

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 30 10:17:28 2006

This is an archived mail posted to the Subversion Dev mailing list.