Re: [PROPOSAL] Relaxing diff3 interface requirements documentation

Erik Huelsmann wrote:
> On 6/25/06, Julian Foad <julianfoad@btopenworld.com> wrote:
>
>> The old text "must be full paths" was poor (not clear whether it meant
>> "absolute") but if relative paths are to be allowed you need to say
>> what they are relative to.
>
> Hmm. Why? svn_io_file_open() says nothing about absolute or relative
> paths and what they are relative to. I think that's implicit.

Yes, OK, I suppose it is implicit in many functions that relative paths are
relative to the current working directory. We just need to be careful in
documenting functions that have another possible context to use, like the one
below.

>> Same here: [for svn_io_run_diff3_2()]
>
> Well, since they aren't relative to the current working directory, I
> agree with you on this point. I'll add that.
>
> Thanks for your comments!

By the way, +1 on doing this and then avoiding copying files in the caller
svn_wc_merge2() like you said. Well spotted.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 25 12:32:09 2006