[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PROPOSAL] Relaxing diff3 interface requirements documentation

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2006-06-25 08:55:00 CEST

On 6/25/06, Julian Foad <julianfoad@btopenworld.com> wrote:
> Erik Huelsmann wrote:
> > - * the difference between an @a original file, @a modified file, and @a
> > latest
> > - * file. (The file arguments must be full paths to the files.)
> > + * the difference between an @a original file, @a modified file, and @a
> > latest
> > + * file.
>
> The old text "must be full paths" was poor (not clear whether it meant
> "absolute") but if relative paths are to be allowed you need to say what they
> are relative to.

Hmm. Why? svn_io_file_open() says nothing about absolute or relative
paths and what they are relative to. I think that's implicit.

> > - * @a mine, @a older, and @a yours are utf8-encoded paths, relative to
> > @a dir,
> > - * to three files that already exist. @a merged is an open file
> > handle, and
> > + * @a mine, @a older and @a yours are utf8-encoded paths to three files
> > + * that already exist. @a merged is an open file handle, and
>
> Same here: you can't just remove that text. Change it to something like
> "(absolute, or relative to @a dir)".

Well, since they aren't relative to the current working directory, I
agree with you on this point. I'll add that.

Thanks for your comments!

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 25 08:55:30 2006

This is an archived mail posted to the Subversion Dev mailing list.