[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] tools/dev/contribulyze.py

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-06-24 08:01:57 CEST

Madan U Sreenivasan wrote:
> On Sat, 24 Jun 2006 00:12:02 +0530, Kamesh Jayachandran
> <kamesh@collab.net> wrote:
>
> @@ -245,6 +244,8 @@
> username = None
> real_name = None
> email = None
> + if name[-1] == ',':
> + name = name[0:-1]
>
> We would be better of tweaking the regex in_field_re in graze().
>
Contributor.parse is the right place, so this change.
>
>> [[[
>> Patch by: Kamesh Jayachandran <kamesh@collab.net>
>>
>> * tools/dev/contribulyze.py
>> remove unused import 'shutil'
>
> This is a different change. Pl. avoid the temptation to bundle simple
> unrelated changes together. :)
>
Will make it part of someother patch.

>> ignore a ',' at the end of Patch-by: line.
>
> Also, pl. look at hacking.html and follow the log format. The function
> names should be provided in brackets, like:
>
> (Contributor.parse): ignore a ',' at the end of Patch-by: line.
>
Taken care.

Find the attached patch.

Thanks for the review.

With regards
Kamesh Jayachandran

[[[
Patch by: Kamesh Jayachandran <kamesh@collab.net>

* tools/dev/contribulyze.py
  (Contributor.parse): ignore a ',' at the end of 'Patch by': line.
]]]

Index: tools/dev/contribulyze.py
===================================================================
--- tools/dev/contribulyze.py (revision 20225)
+++ tools/dev/contribulyze.py (working copy)
@@ -245,6 +245,8 @@
     username = None
     real_name = None
     email = None
+ if name[-1] == ',':
+ name = name[0:-1]
     name_components = name.split()
     if len(name_components) == 1:
       name = name_components[0] # Effectively, name = name.strip()

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 24 08:01:27 2006

This is an archived mail posted to the Subversion Dev mailing list.