[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] tools/dev/contribulyze.py

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-06-24 03:16:24 CEST

On Sat, 24 Jun 2006 00:12:02 +0530, Kamesh Jayachandran
<kamesh@collab.net> wrote:

@@ -245,6 +244,8 @@
      username = None
      real_name = None
      email = None
+ if name[-1] == ',':
+ name = name[0:-1]

We would be better of tweaking the regex in_field_re in graze().

> [[[
> Patch by: Kamesh Jayachandran <kamesh@collab.net>
>
> * tools/dev/contribulyze.py
> remove unused import 'shutil'

This is a different change. Pl. avoid the temptation to bundle simple
unrelated changes together. :)

> ignore a ',' at the end of Patch-by: line.

Also, pl. look at hacking.html and follow the log format. The function
names should be provided in brackets, like:

(Contributor.parse): ignore a ',' at the end of Patch-by: line.

Regards,
Madan U S
www.symonds.net/~madan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 23 21:47:04 2006

This is an archived mail posted to the Subversion Dev mailing list.