[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Speedup the python tests (now with log message)

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2006-06-18 21:48:12 CEST

 

> -----Original Message-----
> From: Julian Foad [mailto:julianfoad@btopenworld.com]
> Sent: zondag 18 juni 2006 21:44
>
> Why only for FSFS? It would be nice if the comment could give a hint.

Well, apparently long ago the choice was made to use svnadmin dump|svnadmin
load for bdb, because that would require access to the BDB tools, so I
didn't want to touch that. I'll include a note in the log message.

> >>+ if (fs_type == "fsfs" or fs_type is None) and not ignore_uuid:
>
> This "fs_type is None" seems to be embedding knowlege of
> svnadmin's default, which is not a good idea if it can be
> avoided. One way of avoiding it might be for this test suite
> to decide on its own default (by initialising the global
> variable "fs_type" to "fsfs") so that fs_type is never None.
> That way this conditional would not be able to get out of
> sync with the type of repository that gets created. The test
> suite's default repository type would then be FSFS even if
> svnadmin's default were changed, but I don't see a problem in that.

I was looking at that as well, you're right, I made the wrong choice here.
I'll update it. Probably commit this separately from the speedup patch.
 
> Other than that, this looks fine and I'm happy with the
> principle of copying repositories and WCs to speed up the test suite.
Ok, cool, thanks for the review.

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 18 21:53:14 2006

This is an archived mail posted to the Subversion Dev mailing list.