Re: [PATCH] Speedup the python tests (now with log message)

Lieven Govaerts wrote:
>>Index: subversion/tests/cmdline/svntest/main.py
>>===================================================================
[...]
>>+ # If the repo is fsfs and the copy may have the same uuid, then just copy
>>+ # the repos files on disk.

Why only for FSFS? It would be nice if the comment could give a hint.

>>+ if (fs_type == "fsfs" or fs_type is None) and not ignore_uuid:

This "fs_type is None" seems to be embedding knowlege of svnadmin's default,
which is not a good idea if it can be avoided. One way of avoiding it might be
for this test suite to decide on its own default (by initialising the global
variable "fs_type" to "fsfs") so that fs_type is never None. That way this
conditional would not be able to get out of sync with the type of repository
that gets created. The test suite's default repository type would then be FSFS
even if svnadmin's default were changed, but I don't see a problem in that.

Other than that, this looks fine and I'm happy with the principle of copying
repositories and WCs to speed up the test suite.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 18 21:44:20 2006